RFR: 8340420: ZGC: Should call `vm_shutdown_during_initialization` if initialization fails [v4]
Stefan Karlsson
stefank at openjdk.org
Mon Sep 30 08:06:37 UTC 2024
On Mon, 30 Sep 2024 07:52:49 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:
>> ZGC does not call `vm_shutdown_during_initialization` if initialization fails during the setup of the CollectedHeap, in contrast to the other GC.
>>
>> I propose we add a `ZInitialize::error` which we can use during initialisation to record errors. The first error recored is also stored and used as the error message when shutting down the VM.
>>
>> Initially used malloc to allocate the error (ed9ba5dd6805291a6b1b56566c933424230d3b4a) but feels like it is just better to have static storage for the string and not have to care about malloc potentially failing to allocate.
>
> Axel Boldt-Christmas has updated the pull request incrementally with one additional commit since the last revision:
>
> Fix indentation
Marked as reviewed by stefank (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/21254#pullrequestreview-2336692694
More information about the hotspot-dev
mailing list