RFR: 8329597: C2: Intrinsify Reference.clear [v3]

Aleksey Shipilev shade at openjdk.org
Mon Sep 30 16:50:13 UTC 2024


On Fri, 27 Sep 2024 23:51:13 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:

>> Aleksey Shipilev has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Amend the test case for guaranteing it works under different compilation regimes
>
> src/java.base/share/classes/java/lang/ref/Reference.java line 420:
> 
>> 418:     /* Implementation of clear(), also used by enqueue().  A simple
>> 419:      * assignment of the referent field won't do for some garbage
>> 420:      * collectors.
> 
> Description of clear0 is rendered stale by this change.  The first sentence is no longer true, since it's now
> clearImpl that has that role.  The second sentence probably ought to also be moved into the description of
> clearImpl.

Thanks! I tightened up comments a bit, take another look?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20139#discussion_r1781452602


More information about the hotspot-dev mailing list