RFR: 8353325: Rewrite appcds/methodHandles test cases to use CDSAppTester
Calvin Cheung
ccheung at openjdk.org
Tue Apr 1 01:31:23 UTC 2025
On Mon, 31 Mar 2025 23:08:13 GMT, Ioi Lam <iklam at openjdk.org> wrote:
> These test cases are rewritten to use CDSAppTester, so that they can also be executed in the new JEP 483 workflow (with `-XX:AOTCache=xxx`, etc). This will increase coverage of current and upcoming AOT features (such as AOT linking of invokedynamic, and AOT method profiling).
>
> These test cases are generated by a bash script. This PR minimizes the generated part so that the main portions of the tests can be modified as a normal java source file.
Just one nit. Which tiers testing have been run with this change?
test/hotspot/jtreg/runtime/cds/appcds/methodHandles/JDKMethodHandlesTestRunner.java line 40:
> (failed to retrieve contents of file, check the PR for context)
Pre-existing:
Can you also remove the comment `System.out.println` at line 138?
-------------
Marked as reviewed by ccheung (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24340#pullrequestreview-2730848982
PR Review Comment: https://git.openjdk.org/jdk/pull/24340#discussion_r2021985035
More information about the hotspot-dev
mailing list