RFR: 8353129: CDS ArchiveRelocation tests fail after JDK-8325132 [v2]

[David Holmes]

On Mon, 31 Mar 2025 22:15:39 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

>> Two archive relocation tests failed when `-XX:ArchiveRelocationMode=0` is specified via the jtreg `-javaoption`.
>> A fix is to add a `WhiteBox.getArchiveRelocationMode()` method so that the tests can check if the `ArchiveRelocationMode` is set to 0 before checking the expected output.
>> 
>> Passed tiers 1 - 4 testing.
>
> Calvin Cheung has updated the pull request incrementally with one additional commit since the last revision:
> 
>   simplify the fix per David's suggestion

LGTM2. I hope it now passes tier4.

Thanks

src/hotspot/share/prims/whitebox.cpp line 2136:

> 2134: WB_ENTRY(jint, WB_GetArchiveRelocationMode(JNIEnv* env, jobject wb))
> 2135: #if INCLUDE_CDS
> 2136:   return (jint)ArchiveRelocationMode;

Nit: do we need casts between int and jint ??

-------------

Marked as reviewed by dholmes (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24308#pullrequestreview-2728076618
PR Review Comment: https://git.openjdk.org/jdk/pull/24308#discussion_r2020303125