RFR: 8352645: Add tool support to check order of includes [v6]
Doug Simon
dnsimon at openjdk.org
Tue Apr 1 15:39:18 UTC 2025
On Tue, 1 Apr 2025 09:25:17 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
>> Doug Simon has updated the pull request incrementally with one additional commit since the last revision:
>>
>> convert Windows path to Unix path
>
> test/hotspot/jtreg/TEST.groups line 142:
>
>> 140:
>> 141: tier1_common = \
>> 142: sources \
>
> I don't understand this change. How does this end up doing anything different than before?
This makes `sources` be tested in GHA: https://github.com/openjdk/jdk/blob/a1ab1d8de411aace21decd133e7e74bb97f27897/.github/workflows/test.yml#L88
An alternative would be to add a separate GHA jobs just for `sources`:
- test-name: 'hs/tier1 sources'
test-suite: 'test/hotspot/jtreg/:tier1_sources'
debug-suffix: -debug
Given how small `sources` is ([currently only 1 test](https://github.com/openjdk/jdk/tree/master/test/hotspot/jtreg/sources)), it felt like it should just be folded into common.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24247#discussion_r2023111780
More information about the hotspot-dev
mailing list