RFR: 8353325: Rewrite appcds/methodHandles test cases to use CDSAppTester [v2]

Ioi Lam iklam at openjdk.org
Tue Apr 1 15:45:39 UTC 2025


On Tue, 1 Apr 2025 01:28:32 GMT, Calvin Cheung <ccheung at openjdk.org> wrote:

> Just one nit. Which tiers testing have been run with this change?

I ran tiers 1-6. The only problem I encountered was https://github.com/openjdk/jdk/pull/24347 , which I will integrate before integrating this PR.

> test/hotspot/jtreg/runtime/cds/appcds/methodHandles/JDKMethodHandlesTestRunner.java line 40:
> 
>> (failed to retrieve contents of file, check the PR for context)
> Pre-existing:
> Can you also remove the comment `System.out.println` at line 138?

Fixed.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24340#issuecomment-2769799036
PR Review Comment: https://git.openjdk.org/jdk/pull/24340#discussion_r2023118962


More information about the hotspot-dev mailing list