RFR: 8349211: Add support for intrusive trees to the utilities red-black tree [v16]

Casper Norrbin cnorrbin at openjdk.org
Wed Apr 2 08:20:09 UTC 2025


On Tue, 1 Apr 2025 07:07:56 GMT, Axel Boldt-Christmas <aboldtch at openjdk.org> wrote:

>> Casper Norrbin has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   axel feedback
>
> src/hotspot/share/utilities/rbTree.inline.hpp line 621:
> 
>> 619:     assert_leq(from, start);
>> 620:     assert_geq(to, start);
>> 621:   }
> 
> Not sure if we should add an else branch here where we assert end == nullptr / end == start. But given that we will more than likely just crash when reading `start->next()`, it does not matter to much. Regardless of any assert, a bad interval will crash early.

Added an assert just in case.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23416#discussion_r2024312957


More information about the hotspot-dev mailing list