RFR: 8351491: Add info from release file to hserr file [v2]

Magnus Ihse Bursie ihse at openjdk.org
Thu Apr 3 09:09:49 UTC 2025


On Thu, 3 Apr 2025 08:20:56 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:

>  So the load should not really add up much .

You are most likely absolutely right. On an old-style physical hard drive, there might be some additional delay, assuming that the files themselves are contiguous, but not next to each other. I doubt there is any way whatsoever that you could should any performance impact by doing this, it will completely drown in the noise.

Normally, I live and die by the Rules of Optimizations:
1) Don't optimize.
2) (Only for experts) Don't optimize yet.

That is, trying to guess if a piece of code would be bad for performance, without measuring, and writing worse code as a result of this guess, is a really bad engineering principle.

But I also understand David's gut reaction. Hotspot (and the entire JDK) is a complex piece of software that has a high level of performance requirements, and there are a lot of "small cuts" that can overall lead to worse performance, even if every one of them is hard to measure.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24244#issuecomment-2774987280


More information about the hotspot-dev mailing list