RFR: 8350182: [s390x] Relativize locals in interpreter frames [v2]
Amit Kumar
amitkumar at openjdk.org
Thu Apr 3 12:43:26 UTC 2025
On Thu, 3 Apr 2025 06:20:47 GMT, Lutz Schmidt <lucy at openjdk.org> wrote:
>> Amit Kumar has updated the pull request incrementally with one additional commit since the last revision:
>>
>> use Z_R0 as helper
>
> src/hotspot/cpu/s390/templateInterpreterGenerator_s390.cpp line 1145:
>
>> 1143: __ z_stg(Z_R1, _z_ijava_state_neg(locals), fp);
>> 1144:
>> 1145: __ z_lgr(Z_R1, Z_R0); // restore R1
>
> Why don't you use Z_R0 for the relativation calculations and leave Z_R1 untouched? That will avoid the save/restore overhead.
updated.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23660#discussion_r2026912409
More information about the hotspot-dev
mailing list