RFR: 8353365: TOUCH_ASSERT_POISON clears GetLastError()

[Thomas Stuefe]

On Fri, 4 Apr 2025 05:43:36 GMT, David Holmes <dholmes at openjdk.org> wrote:

> This is a very simple fix to save/restore the "last error" value on Windows, so that the TOUCH_ASSERT_POISON mechanism used in assert/guarantee/fatal, does not clear it.
> 
> Testing
>  - new Windows-only gtest added to vmErrors test group
>  - tiers 103 sanity
> 
> Thanks.

Oh, sorry for that. Thanks @stefank @dholmes-ora for finding and fixing this. The patch is fine.

I wonder whether we have the same problem on Posix with errno, but I assume we don't call any functions there that modify errno.

-------------

Marked as reviewed by stuefe (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24435#pullrequestreview-2741882984