RFR: 8351491: Add info from release file to hserr file [v3]

[David Holmes]

On Fri, 4 Apr 2025 06:00:52 GMT, Thomas Stuefe <stuefe at openjdk.org> wrote:

> > @tstuefe perhap this is over engineered but there are a number of issues to consider:
> > ```
> > * reading from the physical filesystem is not the same as reading from /proc and IMO is far more likely to be problematic if done in a signal handling context during error reporting - hence we need to read the file ahead-of-time
> > ```
> 
> But we already do exactly that. We read the Elf- and Dwarf-files to print out the symbol and stack information. From the same filesystem. And these are way larger than the release file, and we don't read sequentially, but seek around. This generates a ton of IO. Reading a small file sequentially is fine in comparison.

Yes we do read those, or attempt to, and doing so is risky and may not work. So do we just keep adding more and risky things to error reporting and keeping hoping it will all "just work"? If we can avoid such a risk, without undue cost/effort shouldn't we do so?
 
> I also don't follow the arguments: the argument for this is that the file system could be slow or IO could be broken in some form.

Two different arguments. Reading the file from a signal handling context may not work. Reading the file from disk during startup adds to the startup overhead.

Again, why not avoid these issues when there is a simple way to do so?

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24244#issuecomment-2777680663