RFR: 8353365: TOUCH_ASSERT_POISON clears GetLastError()

[Thomas Stuefe]

On Fri, 4 Apr 2025 07:55:25 GMT, Julian Waters <jwaters at openjdk.org> wrote:

>> @TheShermanTanker - This test is checking the problem use-case that led to this change, where the
>> value of the `GetLastError` call was clobbered when done as an argument to `fatal`, because the
>> `TOUCH_ASSERT_POISON` happened before the call to `GetLastError`.
>
> Ah, alright. Thanks for the explanation

And `fatal` does not return. It ends the VM with an assertion message. google death tests scan for that message on stderr.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24435#discussion_r2028357519