RFR: 8351319: AOT cache support for custom class loaders broken since JDK-8348426 [v3]
Matias Saavedra Silva
matsaave at openjdk.org
Fri Apr 4 23:47:51 UTC 2025
On Fri, 4 Apr 2025 21:53:13 GMT, Ioi Lam <iklam at openjdk.org> wrote:
>> Since [JDK-8348426](https://bugs.openjdk.org/browse/JDK-8348426) (Generate binary file for -XX:AOTMode=record -XX:AOTConfiguration=file), the AOT cache no longer contains classes intended for custom class loaders (these are called "unregistered classes" in CDS terminology).
>>
>> The fix is simple -- we already remember the set of unregistered classes in the AOT configuration file. We just need to add them into the final AOT cache (see changes in finalImageRecipes.cpp).
>
> Ioi Lam has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains four commits:
>
> - Avoid duplicated unregistered classes that have the same name
> - Merge branch 'master' into 8351319-support-for-custom-loaders-missing-since-jdk-8348426
> - Merge branch 'master' into 8351319-support-for-custom-loaders-missing-since-jdk-8348426
> - 8351319: AOT cache support for custom class loaders broken since JDK-8348426
Changes look good!
-------------
Marked as reviewed by matsaave (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/23926#pullrequestreview-2744283339
More information about the hotspot-dev
mailing list