RFR: 8353365: TOUCH_ASSERT_POISON clears GetLastError() [v2]

David Holmes dholmes at openjdk.org
Sun Apr 6 22:50:28 UTC 2025


> This is a very simple fix to save/restore the "last error" value on Windows, so that the TOUCH_ASSERT_POISON mechanism used in assert/guarantee/fatal, does not clear it.
> 
> Testing
>  - new Windows-only gtest added to vmErrors test group
>  - tiers 103 sanity
> 
> Thanks.

David Holmes has updated the pull request incrementally with one additional commit since the last revision:

  Adjust format specifier and remove cast

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24435/files
  - new: https://git.openjdk.org/jdk/pull/24435/files/c080c068..9a03b3bf

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24435&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24435&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 0 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/24435.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24435/head:pull/24435

PR: https://git.openjdk.org/jdk/pull/24435


More information about the hotspot-dev mailing list