RFR: 8353439: Shell grouping of -XX:OnError= commands is surprising [v2]

[Kevin Walls]

On Sun, 6 Apr 2025 22:38:22 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Test udpate - multiple -XX:OnError=
>
> src/hotspot/share/utilities/vmError.cpp line 149:
> 
>> 147: 
>> 148:   // skip leading blanks, ';' or newlines
>> 149:   while (*cmd == ' ' || *cmd == ';' || *cmd == '\n') cmd++;
> 
> It may be worth reinstating a comment in the function description to explain how the command is actually parsed (we seem to have lost that somewhere along the line) e.g.
> 
> // The command string is expected to be a semi-colon, or newline, delineated sequence of commands,
> // that are executed sequentially and in their own shell environment.

Thanks David - yes, trying a new comment to introduce next_OnError_command more clearly.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24354#discussion_r2030969685