RFR: 8344883: Force clients to explicitly pass mem_tag value, even if it is mtNone [v8]

[Gerard Ziemski]

On Thu, 3 Apr 2025 11:16:43 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

>> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   The real feedback from StefanK
>
> src/hotspot/share/runtime/os.hpp line 527:
> 
>> 525: 
>> 526:   static char*  map_memory(int fd, const char* file_name, size_t file_offset,
>> 527:                            char *addr, size_t bytes, MemTag mem_tag, bool read_only = false,
> 
> AFAICT, there's no need to have a default value for read_only. I think we should remove this default value and move the MemTag parameter so that it comes after read_only and before allow_exec. This would make the parameter order more consistent with the other functions that accept a mem_tag and an executable.
> 
> Given that you have tested the current patch, I'm fine with doing this as a small follow-up patch.

Filed [NMT: change map_memory() signature to match other functions](https://bugs.openjdk.org/browse/JDK-8353854)

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24282#discussion_r2031217805