RFR: 8351491: Add info from release file to hserr file [v3]

Matthias Baesken mbaesken at openjdk.org
Mon Apr 7 14:11:02 UTC 2025


On Fri, 4 Apr 2025 01:50:30 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use one time PeriodicTask
>
> src/hotspot/share/runtime/os.cpp line 1564:
> 
>> 1562:       size_t elements_read = fread(_image_release_file_content, 1, sz, file);
>> 1563:       if (elements_read < (size_t)sz) _image_release_file_content[elements_read] = '\0';
>> 1564:       _image_release_file_content[sz] = '\0';
> 
> Shouldn't this be in an else?

Yeah we probably (most likely) only need one '\0' .

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24244#discussion_r2031331768


More information about the hotspot-dev mailing list