RFR: 8353365: TOUCH_ASSERT_POISON clears GetLastError() [v2]
David Holmes
dholmes at openjdk.org
Mon Apr 7 23:39:17 UTC 2025
On Sun, 6 Apr 2025 22:50:28 GMT, David Holmes <dholmes at openjdk.org> wrote:
>> This is a very simple fix to save/restore the "last error" value on Windows, so that the TOUCH_ASSERT_POISON mechanism used in assert/guarantee/fatal, does not clear it.
>>
>> Testing
>> - new Windows-only gtest added to vmErrors test group
>> - tiers 103 sanity
>>
>> Thanks.
>
> David Holmes has updated the pull request incrementally with one additional commit since the last revision:
>
> Adjust format specifier and remove cast
Thanks for the reviews!
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24435#issuecomment-2784862100
More information about the hotspot-dev
mailing list