RFR: 8351491: Add info from release file to hserr file [v4]

[David Holmes]

On Tue, 8 Apr 2025 07:58:02 GMT, David Holmes <dholmes at openjdk.org> wrote:

>> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   use stringStream in os.cpp, add a couple of changes suggested by David
>
> src/hotspot/share/runtime/os.cpp line 1538:
> 
>> 1536:   ss.print("%s/release", home);
>> 1537: 
>> 1538:   if (_image_release_file_content == nullptr) {
> 
> Shouldn't we check before doing anything else i.e. make line 1538 first.
> 
> Also for race concerns use load_acquire on `image_release_file_content`.

Though actually shouldn't this just be an assert as we only expect this to be called once.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24244#discussion_r2032626089