RFR: 8353439: Shell grouping of -XX:OnError= commands is surprising [v3]
Thomas Stuefe
stuefe at openjdk.org
Tue Apr 8 13:45:22 UTC 2025
On Mon, 7 Apr 2025 10:44:02 GMT, Kevin Walls <kevinw at openjdk.org> wrote:
>> We should be consistent, and run all OnError items in a new shell. Currently the ; separator causes a new shell, but multiple -XX:OnError= options are grouped into the same shell.
>>
>> next_OnError_command() decides on where a new command starts. It should recognise newlines, and all commands will get their own shell.
>
> Kevin Walls has updated the pull request incrementally with one additional commit since the last revision:
>
> comment
Looks good to me.
-------------
Marked as reviewed by stuefe (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24354#pullrequestreview-2750035837
More information about the hotspot-dev
mailing list