RFR: 8351491: Add info from release file to hserr file [v6]
David Holmes
dholmes at openjdk.org
Tue Apr 8 22:27:34 UTC 2025
On Tue, 8 Apr 2025 13:09:10 GMT, Matthias Baesken <mbaesken at openjdk.org> wrote:
>> The release file of the JDK image contains useful info, for example the SOURCE used to built this image e.g.
>> SOURCE=".:git:21af8c7e7405"
>> Also the MODULES list is probably useful to have.
>> Add this info (or the complete content of the release file) to the hs_err files.
>
> Matthias Baesken has updated the pull request incrementally with one additional commit since the last revision:
>
> print_image_release_file use load_acquire
LGTM. One final suggestion but pre-approved.
src/hotspot/share/runtime/os.cpp line 1576:
> 1574: if (ifrc != nullptr) {
> 1575: st->print_cr("%s", ifrc);
> 1576: }
Do we want:
} else {
st->print_cr("<release file has not been read>");
}
or some such message?
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24244#pullrequestreview-2751536372
PR Review Comment: https://git.openjdk.org/jdk/pull/24244#discussion_r2034114309
More information about the hotspot-dev
mailing list