RFR: 8353189: [ASAN] memory leak after 8352184 [v3]
David Holmes
dholmes at openjdk.org
Wed Apr 9 02:40:30 UTC 2025
On Tue, 8 Apr 2025 03:55:03 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Hi all,
>>
>> This PR will try to fix memory leak after JDK-8352184. which re-do [JDK-8352184](https://bugs.openjdk.org/browse/JDK-8352184) using the original, purely static uses of the various description strings, as @jianglizhou had proposed.
>>
>> Additional testing:
>>
>> - [x] jtreg tests(include tier1/2/3 etc.) on linux-x64
>> - [x] jtreg tests(include tier1/2/3 etc.) on linux-aarch64
>> - [x] full `java -version` tests, the test shell script show as below.
>>
>> [JDK-8353189.sh.txt](https://github.com/user-attachments/files/19643535/JDK-8353189.sh.txt)
>
> SendaoYan has updated the pull request incrementally with one additional commit since the last revision:
>
> add a comment to explain why we avoid dynamic memory allocation for the vm_info_string
This looks good to me. Sorry for the delay in getting it reviewed.
Thanks for fixing this.
-------------
Marked as reviewed by dholmes (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24299#pullrequestreview-2751895602
More information about the hotspot-dev
mailing list