Integrated: 8324686: Remove redefinition of NULL for MSVC
Kim Barrett
kbarrett at openjdk.org
Thu Apr 10 10:24:36 UTC 2025
On Wed, 9 Apr 2025 06:16:18 GMT, Kim Barrett <kbarrett at openjdk.org> wrote:
> Please review this change that removes the redefinition of NULL in
> globalDefinitions_visCPP.hpp. That redefinition was to support the use of NULL
> in a varargs context, because of the size difference for int vs a pointer.
> However, we no longer have any direct uses of NULL in HotSpot, and have a test
> that ensures there is no backsliding.
>
> There may be indirect uses of NULL via third-party libraries. Such uses could
> have been in the scope of the removed redefinition. But those uses must have
> been correct even without the redefinition, else they would be incorrect for
> non-HotSpot users.
>
> Testing: mach5 tier1-3, GHA sanity tests
This pull request has now been integrated.
Changeset: 6c266701
Author: Kim Barrett <kbarrett at openjdk.org>
URL: https://git.openjdk.org/jdk/commit/6c2667018a49ac78c3a01dc4d52ff6cdf39b7647
Stats: 21 lines in 2 files changed: 0 ins; 20 del; 1 mod
8324686: Remove redefinition of NULL for MSVC
Reviewed-by: shade, dholmes
-------------
PR: https://git.openjdk.org/jdk/pull/24537
More information about the hotspot-dev
mailing list