RFR: 8351666: [PPC64] Make non-volatile VectorRegisters available for C2 register allocation [v4]

Martin Doerr mdoerr at openjdk.org
Thu Apr 10 15:12:44 UTC 2025


On Wed, 9 Apr 2025 10:26:25 GMT, Richard Reingruber <rrich at openjdk.org> wrote:

>> Martin Doerr has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Update Copyright header.
>
> src/hotspot/cpu/ppc/ppc.ad line 1934:
> 
>> 1932:   if (reg < 136+256) return rc_vs;
>> 1933: 
>> 1934:   assert(OptoReg::is_stack(reg), "what else is it?");
> 
> Maybe add
> ```c++
>   assert(_last_Mach_Reg == 398, "hardcoded register indices need to be updated from enum MachRegisterNumbers");

Shouldn't the existing assertion catch all problematic cases?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23987#discussion_r2037648881


More information about the hotspot-dev mailing list