RFR: 8351666: [PPC64] Make non-volatile VectorRegisters available for C2 register allocation [v4]
    Martin Doerr 
    mdoerr at openjdk.org
       
    Thu Apr 10 15:12:46 UTC 2025
    
    
  
On Wed, 9 Apr 2025 17:24:19 GMT, Richard Reingruber <rrich at openjdk.org> wrote:
>> src/hotspot/cpu/ppc/stubGenerator_ppc.cpp line 220:
>> 
>>> 218:       BLOCK_COMMENT("Call frame manager or native entry.");
>>> 219:       // Call frame manager or native entry.
>>> 220:       assert_different_registers(r_arg_entry, r_top_of_arguments_addr, r_arg_method, r_arg_thread);
>> 
>> Since you're at it: please adjust the 2 comment lines above: there's no frame manager. We're about to call the interpreter or native entry.
>> Also L222 (just remove "on entry ..."), L245. L265
>
> Alternatively create a cleanup RFE for the stale "frame manager" comments.
I think a separate RFE will be better because "frame manager" is still referenced at more places.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23987#discussion_r2037651201
    
    
More information about the hotspot-dev
mailing list