RFR: 8353786: Migrate Vector API math library support to FFM API [v4]

Vladimir Kozlov kvn at openjdk.org
Thu Apr 10 21:42:37 UTC 2025


On Mon, 7 Apr 2025 23:20:05 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:

>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/CPUFeatures.java line 60:
>> 
>>> 58:     }
>>> 59: 
>>> 60:     public static class X64 {
>> 
>> Should we create `src/jdk.incubator.vector/cpu/` for CPU specific information? As separate refactoring.
>
> To clarify: are you suggesting to move platform-specific classes into a separate package or platform-specific location? 
> 
> It does make sense to separate platform-specific parts into their own classes once amount of code grows over some limit. For now it doesn't look too attractive since amount of code is very small.

ok

>> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMathLibrary.java line 100:
>> 
>>> 98: 
>>> 99:     /**
>>> 100:      * Naming convention in SVML vector math library.
>> 
>> Does this library has code for all AVX configurations?
>
> Yes, there are 4 configurations (`-XX:UseAVX=[0..3]`) in total covered by SVML library.

Good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24462#discussion_r2038379482
PR Review Comment: https://git.openjdk.org/jdk/pull/24462#discussion_r2038379716


More information about the hotspot-dev mailing list