RFR: 8354309: Sort GC includes
Stefan Karlsson
stefank at openjdk.org
Fri Apr 11 11:54:29 UTC 2025
On Thu, 10 Apr 2025 16:26:42 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
> We now have a tool to fix our include lines to better adhere to the HotSpot Style Guide. See test/hotspot/jtreg/sources/SortIncludes.java. I've run the tool against the GC code and propose the resulting changes. I did one manual change to move a section guarded with INCLUDE_JFR.
>
> Builds successfully with GHA. I will run this through tier1-2.
I don't think my patch *needs* to add this to the test.
Adding the GC directories to the test will make a small mistake in the include order a tier1 failure, and I'm not yet convinced that that is a good thing compared to lazily fixing sort order problems.
Any other Reviewers that have a strong opinion about this?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24581#issuecomment-2796694323
More information about the hotspot-dev
mailing list