RFR: 8353786: Migrate Vector API math library support to FFM API [v5]
Vladimir Ivanov
vlivanov at openjdk.org
Tue Apr 15 17:46:46 UTC 2025
On Tue, 15 Apr 2025 09:29:32 GMT, Xiaohong Gong <xgong at openjdk.org> wrote:
>> Vladimir Ivanov has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 19 additional commits since the last revision:
>>
>> - Merge branch 'master' into vector.math.01.java
>> - RVV and SVE adjustments
>> - Merge branch 'master' into vector.math.01.java
>> - Fix windows-aarch64 build failure
>> - features_string -> cpu_info_string
>> - Reviews and Float64Vector-related fix
>> - Misc fixes and cleanups
>> - CPU features support
>> - Cleanup
>> - TODO list
>> - ... and 9 more: https://git.openjdk.org/jdk/compare/3a706abc...0ffed12f
>
> src/jdk.incubator.vector/share/classes/jdk/incubator/vector/VectorMathLibrary.java line 198:
>
>> 196: if (vspecies.vectorBitSize() < 128) {
>> 197: return false; // 64-bit vectors are not supported
>> 198: }
>
> Thanks for your refactor. It's really a good job!
>
> It seems float type support 64-bit vector operations before (see https://github.com/openjdk/jdk/blob/master/src/hotspot/cpu/aarch64/stubGenerator_aarch64.cpp#L9835). Will this change the behavior of 64-bit float vector? Thanks!
Thanks for taking a look.
In the latest version, Float64Vector cases should be properly handled.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24462#discussion_r2045156970
More information about the hotspot-dev
mailing list