RFR: 8354547: REDO: Force clients to explicitly pass mem_tag value, even if it is mtNone [v3]
Coleen Phillimore
coleenp at openjdk.org
Tue Apr 15 20:17:46 UTC 2025
On Tue, 15 Apr 2025 20:02:07 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:
>> Redo for a follow-up to https://github.com/openjdk/jdk/pull/21843. Here we are focusing on removing the mem tag paremeter with default value of mtNone, to force everyone to provide mem tag, if known.
>>
>> I tried to fill in tag, when I was pretty certain that I had the right type.
>>
>> At least one more follow-up will be needed after this, to change the remaining mtNone to valid values.
>>
>> Testing: passes tier1 locally on my mac, Mach5 tier1-5 in progress
>
> Gerard Ziemski has updated the pull request incrementally with one additional commit since the last revision:
>
> remove last default argument (found by Stefan)
This looks like it'll help remove the inadvertent mtNone categorizations, provided future changes fix the rest of the mtNone to the right categories.
Please take this through a tier1-3 round of testing on your latest change before pushing.
-------------
Marked as reviewed by coleenp (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24634#pullrequestreview-2769691566
More information about the hotspot-dev
mailing list