RFR: 8349405: Redundant and confusing null checks on data from CP::resolved_klasses

David Holmes dholmes at openjdk.org
Wed Apr 16 05:35:40 UTC 2025


On Wed, 16 Apr 2025 04:54:01 GMT, David Holmes <dholmes at openjdk.org> wrote:

> It sounds reasonable that any entry tagged `JVM_CONSTANT_Class` is guaranteed non-null (at least now you fixed the place that set null before changing the tag). But I can't find the primary place where we install a `klass*` into the `resolved_klasses` and tag it as `JVM_CONSTANT_Class`.

Doh! Now I see it:

Atomic::release_store(adr, k);

- not easily greppable.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24665#issuecomment-2808349075


More information about the hotspot-dev mailing list