RFR: 8354523: runtime/Monitor/SyncOnValueBasedClassTest.java triggers SIGSEGV
Roman Kennke
rkennke at openjdk.org
Wed Apr 16 14:40:41 UTC 2025
On Tue, 15 Apr 2025 16:50:07 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
> I wonder if it would be better to zero the cache in InterpreterRuntime::monitorenter and have a C1 entry rather than going directly to monitor_enter_helper. Then we can zero the BasicLock::monitor_cache in the two places where it shouldn't be set.
Yes, there is also a C1 entry where we could do that. It's in Runtime1::monitorenter() in c1_Runtime.cpp.
It would mean another branch on 'if (UseObjectMonitorTable) { .. }' in both entries. I guess that'd be ok-ish? (Hopefully all those different modes would go away soon and we could have a streamlined sync code...)
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24660#issuecomment-2809802153
More information about the hotspot-dev
mailing list