RFR: 8354543: Set more meaningful names for "get_vm_result" and "get_vm_result_2" [v2]
Aleksey Shipilev
shade at openjdk.org
Wed Apr 16 18:53:52 UTC 2025
On Wed, 16 Apr 2025 18:41:26 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:
>> src/hotspot/share/runtime/javaThread.hpp line 788:
>>
>>> 786: // Oop results of vm runtime calls
>>> 787: oop vm_result_oop() const { return _vm_result_oop; }
>>> 788: void set_vm_result_oop(oop x) { _vm_result_oop = x; }
>>
>> Suggestion:
>>
>> void set_vm_result_oop(oop x) { _vm_result_oop = x; }
>
> I don't think John fixed the space here.
Right. But whatever, I won't quibble. @JohnTortugo -- fix it if you can.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24632#discussion_r2047538430
More information about the hotspot-dev
mailing list