RFR: 8349405: Redundant and confusing null checks on data from CP::resolved_klasses [v2]

[David Holmes]

On Wed, 16 Apr 2025 18:23:26 GMT, Coleen Phillimore <coleenp at openjdk.org> wrote:

>> This small cleanup asserts that when we have JVM_CONSTANT_Class tag in the constant pool, the resolved_klasses() contains a non-null Klass.  There were some null checks left over and access to resolved_klasses() should go through resolved_klass_at() whenever possible to hide the CPSlot code.
>> Tested with tier1-8.
>
> Coleen Phillimore has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Move comment to above the lines it describes.

Marked as reviewed by dholmes (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/24665#pullrequestreview-2774496242