RFR: 8349721: Add aarch64 intrinsics for ML-KEM [v11]
Ferenc Rakoczi
duke at openjdk.org
Thu Apr 17 09:43:03 UTC 2025
On Wed, 16 Apr 2025 19:22:51 GMT, Vladimir Ivanov <vlivanov at openjdk.org> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fixed asserts.
>
> src/hotspot/cpu/aarch64/vm_version_aarch64.cpp line 717:
>
>> 715: desc_len = (int)strlen(_cpu_desc);
>> 716: snprintf(_cpu_desc + desc_len, CPU_DETAILED_DESC_BUF_SIZE - desc_len, " %s", _features_string);
>> 717: fprintf(stderr, "_features_string = \"%s\"", _features_string);
>
> Was this line added by mistake? Looks like a leftover.
@iwanowww Oooops, yes. Addressed in [https://github.com/openjdk/jdk/pull/24717](url) together with another forgotten (though not strictly necessary) change. Thanks for catching it!
Could you review that (really short) PR?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/23663#discussion_r2048605624
More information about the hotspot-dev
mailing list