RFR: 8353298: AOT cache creation asserts with _array_klasses in an unregistered InstanceKlass [v2]

Calvin Cheung ccheung at openjdk.org
Fri Apr 18 19:27:40 UTC 2025


On Fri, 18 Apr 2025 19:09:40 GMT, Ioi Lam <iklam at openjdk.org> wrote:

>> The assert in `Klass::remove_java_mirror()` is too narrow. When creating the AOT cache, it's possible to see two types of Klasses that do not have a Java mirror:
>> 
>> - Unregistered classes (a cached class to be loaded by a custom class loader in the production run)
>> - An array type of an unregistered class
>> 
>> I have relaxed the assert to accept both conditions
>
> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Added comments about the purpose of AOTCacheSupportForCustomLoaders.java

Looks good.

-------------

Marked as reviewed by ccheung (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/24711#pullrequestreview-2779277441


More information about the hotspot-dev mailing list