RFR: 8354558: -XX:AOTMode=record crashes with boot loader package-info class [v2]
Ioi Lam
iklam at openjdk.org
Sun Apr 20 00:47:42 UTC 2025
On Sat, 19 Apr 2025 15:22:35 GMT, SendaoYan <syan at openjdk.org> wrote:
>> Ioi Lam has updated the pull request incrementally with one additional commit since the last revision:
>>
>> @calvinccheung comments
>
> test/hotspot/jtreg/runtime/cds/appcds/aotCache/PackageInfoClass.java line 36:
>
>> 34: * @run driver jdk.test.lib.helpers.ClassFileInstaller -jar boot.jar foo.Foo foo.package-info foo.MyAnnotation
>> 35: * @run driver jdk.test.lib.helpers.ClassFileInstaller -jar app.jar PackageInfoClassApp
>> 36: * @run driver PackageInfoClass AOT
>
> Should we use `@run main` instead of `@run driver`
> The `AOT` args for PackageInfoClass, seems do not use in main function?
`PackageInfoClass is` just a simple script for launching child processes. It doesn't take any VM arguments so we can run it in driver mode. It's the child processes that it launches that take VM arguments such as `-XX:AOTCache=xxx`
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24710#discussion_r2051608424
More information about the hotspot-dev
mailing list