RFR: 8354547: REDO: Force clients to explicitly pass mem_tag value, even if it is mtNone [v7]

Gerard Ziemski gziemski at openjdk.org
Tue Apr 22 14:07:42 UTC 2025


On Tue, 22 Apr 2025 12:48:04 GMT, Gerard Ziemski <gziemski at openjdk.org> wrote:

>> Redo for a follow-up to https://github.com/openjdk/jdk/pull/21843. Here we are focusing on removing the mem tag paremeter with default value of mtNone, to force everyone to provide mem tag, if known.
>> 
>> I tried to fill in tag, when I was pretty certain that I had the right type.
>> 
>> At least one more follow-up will be needed after this, to change the remaining mtNone to valid values.
>> 
>> Testing: passes tier1 locally on my mac, Mach5 tier1-5 in progress
>
> Gerard Ziemski has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains eight additional commits since the last revision:
> 
>  - Merge remote-tracking branch 'upstream/master' into JDK-8354547
>  - Merge remote-tracking branch 'upstream/master' into JDK-8354547
>  - Merge remote-tracking branch 'upstream/master' into JDK-8354547
>  - Merge remote-tracking branch 'upstream/master' into JDK-8354547
>  - remove last default argument (found by Stefan)
>  - fix build break
>  - fix build break
>  - redo

Thank you all for reviews. I merged yesterday and ran tier1-3, which passes. I merged again this morning and ran tier1 locally, which passes.

I'm going to integrate as soon as [Pre-submit tests - windows-x64 / test - Test (tier1)](https://github.com/openjdk/jdk/pull/24634/checks?check_run_id=40944629903) finishes.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24634#issuecomment-2821449233


More information about the hotspot-dev mailing list