RFR: 8344734: Rename memoryFileTracker to nativeMemoryFileTracker [v3]

David Holmes dholmes at openjdk.org
Wed Apr 23 02:32:42 UTC 2025


On Tue, 22 Apr 2025 07:57:13 GMT, Anton Artemov <duke at openjdk.org> wrote:

>> Renamed memoryFileTracker to nativeMemoryFileTracker as requested in the issue description, as it makes a better acronym.
>
> Anton Artemov has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains one commit:
> 
>   8344734: renamed memoryFileTracker to nativeMemoryFileTracker

src/hotspot/share/nmt/nativeMemoryFileTracker.hpp line 43:

> 41: // All memory is accounted as committed, there is no reserved memory.
> 42: // Any reserved memory is expected to exist in the VirtualMemoryTracker.
> 43: class NativeMemoryFileTracker {

You need to update the comment at line 38 as well. The problem with adding adjectives into names like this is that it becomes unclear how to parse it: is this a native-MemoryFileTracker, or a NativeMemory-FileTracker? The class comment should make this clear. Thanks.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24579#discussion_r2055153575


More information about the hotspot-dev mailing list