RFR: 8354309: Sort GC includes

Stefan Karlsson stefank at openjdk.org
Wed Apr 23 10:10:21 UTC 2025


On Thu, 10 Apr 2025 16:26:42 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:

> We now have a tool to fix our include lines to better adhere to the HotSpot Style Guide. See test/hotspot/jtreg/sources/SortIncludes.java. I've run the tool against the GC code and propose the resulting changes. I did one manual change to move a section guarded with INCLUDE_JFR.
> 
> Builds successfully with GHA. I will run this through tier1-2.

You can't safely reorder Memoryapi.h and Windows.h when compiling on Windows. I've simply removed the redundant include of Memoryapi.h to get this to compile.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24581#issuecomment-2823776122


More information about the hotspot-dev mailing list