RFR: 8354309: Sort GC includes [v2]
Erik Österlund
eosterlund at openjdk.org
Wed Apr 23 10:16:47 UTC 2025
On Wed, 23 Apr 2025 10:10:20 GMT, Stefan Karlsson <stefank at openjdk.org> wrote:
>> We now have a tool to fix our include lines to better adhere to the HotSpot Style Guide. See test/hotspot/jtreg/sources/SortIncludes.java. I've run the tool against the GC code and propose the resulting changes. I did one manual change to move a section guarded with INCLUDE_JFR.
>>
>> Builds successfully with GHA. I will run this through tier1-2.
>
> Stefan Karlsson has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains four additional commits since the last revision:
>
> - Fix windows compliation error
> - Merge remote-tracking branch 'upstream/master' into 8354309_sort_gc_includes
> - Merge remote-tracking branch 'upstream/master' into 8354309_sort_gc_includes
> - 8354309: Sort GC includes
Still good!
-------------
Marked as reviewed by eosterlund (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/24581#pullrequestreview-2786760983
More information about the hotspot-dev
mailing list