RFR: 8352251: Implement Cooperative JFR Sampling [v11]

Markus Grönlund mgronlun at openjdk.org
Thu Apr 24 09:41:48 UTC 2025


On Thu, 24 Apr 2025 09:06:49 GMT, Aleksey Shipilev <shade at openjdk.org> wrote:

> (Sorry for dripping review comments, I have only limited time a day to look at this)
> 
> Looks like windows-aarch64 GHA build fails with:
> 
> ```
> d:\a\jdk\jdk\src\hotspot\cpu\aarch64\interp_masm_aarch64.cpp(475): error C2039: 'last_sender_Java_fp_offset': is not a member of 'JavaThread'
> d:\a\jdk\jdk\src\hotspot\share\runtime/threads.hpp(34): note: see declaration of 'JavaThread'
> ```
> 
> I suspect the fix is as simple as adding the hunk that you already have in `javaThread_windows_x86.hpp` to `javaThread_windows_aarch64.hpp` as well.

Thats ok.

If we fix the builds, it may hide the need to make the platform changes required, and will fail spectacularly if they are not addressed correctly. I have sent an email to porters-dev.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/24296#issuecomment-2826990739


More information about the hotspot-dev mailing list