RFR: 8355481: Clean up MHN_copyOutBootstrapArguments [v2]

[Johan Sjölen]

> Hi,
> 
> I'd like to integrate this simplification of the code for this loop.
> 
> We used to have:
> 
> ```c++
> if (start < 0) {
>   for (int pseudo_index = -4; pseudo_index < 0; pseudo_index++) {
>     if (start == pseudo_index) {
>       if (start >= end || 0 > pos || pos >= buf->length())  break;
>       // ...
>     }
>     start++;
>   }
> }
> 
> 
> That's exactly the same as:
> 
> 
> int min_end = MIN2(0, end);
> while (-4 <= start && start < min_end) {
>   if (pos >= buf->length()) break;
>   // ...
>   start++;
> }
> 
> 
> but the latter looks like a conventional loop.
> 
> I'd consider this a basic cleanup, which is worth doing in the name of maintainability.
> 
> I would have liked to change the `-4` to `-1` into actual names, but I've no clue where those come from. It doesn't seem worth it to change them if they just happen to be a kludge relying on internal details, or something like that.
> 
> Testing: GHA Tier1

Johan Sjölen has updated the pull request incrementally with one additional commit since the last revision:

  Remove whitespace

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/24825/files
  - new: https://git.openjdk.org/jdk/pull/24825/files/e8884a2f..e3a6f53a

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=24825&range=01
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=24825&range=00-01

  Stats: 1 line in 1 file changed: 0 ins; 1 del; 0 mod
  Patch: https://git.openjdk.org/jdk/pull/24825.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/24825/head:pull/24825

PR: https://git.openjdk.org/jdk/pull/24825