RFR: JDK-8216437 : PPC64: Add intrinsic for GHASH algorithm [v29]
Suchismith Roy
sroy at openjdk.org
Thu Apr 24 14:13:51 UTC 2025
On Thu, 24 Apr 2025 03:55:47 GMT, Amit Kumar <amitkumar at openjdk.org> wrote:
>> Suchismith Roy has updated the pull request incrementally with three additional commits since the last revision:
>>
>> - comments
>> - comments
>> - comments
>
> src/hotspot/cpu/ppc/stubGenerator_ppc.cpp line 556:
>
>> 554: // The multiplication results are reduced using `vConstC2` to stay within GF(2^128).
>> 555: // The final computed value is stored back into `vState`.
>> 556: static void computeGCMProduct(MacroAssembler* masm,
>
> Suggestion:
>
> static void computeGCMProduct(MacroAssembler* _masm,
>
>
> This way you don't have to use `masm->` in this method, you can just use `__` as usual.
Done. Thanks
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20235#discussion_r2058544543
More information about the hotspot-dev
mailing list