RFR: 8345125: Aarch64: Add aarch64 backend for Float16 scalar operations [v4]

Bhavana Kilambi bkilambi at openjdk.org
Fri Apr 25 10:36:04 UTC 2025


On Fri, 25 Apr 2025 08:33:16 GMT, Bhavana Kilambi <bkilambi at openjdk.org> wrote:

>> This patch adds aarch64 backend for scalar FP16 operations namely - add, subtract, multiply, divide, fma, sqrt, min and max.
>
> Bhavana Kilambi has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Update asmtest.out.h to keep it consistent with aarch64-asmtest.py

> On 4/25/25 10:17, bkilambi wrote: Bhavana-Kilambi left a comment ([openjdk/jdk#23748](https://github.com/openjdk/jdk/pull/23748)) > Looks good to me. Please summarize the tests that you've run before committing. Thank you for the approval. All hotspot (hotspot_all), jdk (tiers 1-3) and langtools (tier1) pass on N1, V1 and V2 architectures.
> But do any of these tests use Float16 ?
> […](#)
> -- Andrew Haley (he/him) Java Platform Lead Engineer Red Hat UK Ltd. <https://www.redhat.com> https://keybase.io/andrewhaley EAC8 43EB D3EF DB98 CC77 2FAD A5CD 6035 332F A671

Yes they do.
The following FP16 tests are included in them and have also been tested separately (these are the ones which have been added/modified in the commit which added initial scalar FP16 support in JDK mainline (https://github.com/openjdk/jdk/commit/4b463ee70eceb94fdfbffa5c49dd58dcc6a6c890) - 


test/hotspot/jtreg/compiler/c2/irTests/ConvF2HFIdealizationTests.java
test/hotspot/jtreg/compiler/c2/irTests/MulHFNodeIdealizationTests.java
test/hotspot/jtreg/compiler/c2/irTests/TestFloat16ScalarOperations.java
test/hotspot/jtreg/compiler/vectorization/TestFloat16VectorConvChain.java
test/jdk/jdk/incubator/vector/ScalarFloat16OperationsTest.java


Please let me know if you'd like me to test anything else. Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/23748#issuecomment-2830039111


More information about the hotspot-dev mailing list