RFR: 8354284: Add more compiler test folders to tier1 runs
Vladimir Kozlov
kvn at openjdk.org
Wed Apr 30 16:59:45 UTC 2025
On Wed, 23 Apr 2025 08:44:04 GMT, Marc Chevalier <mchevalier at openjdk.org> wrote:
> Some folders in jtreg/compiler have been reported not to be run in any tier, while tier1 was probably intended, but the tier definition was mistakenly not updated. I've checked which folders are not referenced into `TEST.groups`.
>
> The unmentioned ones:
> - `ccp`
> - `ciReplay`
> - `ciTypeFlow`
> - `compilercontrol`
> - `debug`
> - `oracle`
> - `predicates`
> - `print`
> - `relocations`
> - `sharedstubs`
> - `splitif`
> - `tiered`
> - `whitebox`
>
> And those, that are not test folders:
> - `lib`
> - `patches`
> - `testlibraries`
>
> I'm adding `ccp`, `ciTypeFlow`, `predicates`, `sharedstubs` and `splitif` to tier1.
>
> The other folders seems to have been around for very long (since at least mid-2021). It's not clear how meaningful it'd be to add them/what the intent from them was. I've rather focused on the recently(-ish) added folders, that one forgot to put in a tier when adding it.
>
> Feel free to tell if other folders should be included (and in which tier).
>
> Thanks,
> Marc
> -XX:RepeatCompilation=300
Based on run's output times this add only 2 sec. I agree to reduce number of iterations (may be 100) but not complete remove it.
> replacing the loop by a mere run()
I would not do that. First compilation of `run()` will be OSR and we will never run it fully compiled. You need several iterations in `main()` to trigger and use normal compilation. But 100 iterations should be fine. This should put execution time under 1 sec.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/24817#issuecomment-2842642683
More information about the hotspot-dev
mailing list