RFR: 8357086: os::xxx functions returning memory size should return size_t [v13]

[Kim Barrett]

On Wed, 30 Jul 2025 13:32:20 GMT, Anton Artemov <duke at openjdk.org> wrote:

> > 1. I really would like to see all the UL "X failed" log lines removed from this patch.
> 
> @stefank I understand your concerns. I can remove the logging for failed cases, but it will demise the proposed pattern. Without consensus on how to log such cases for JVM users, which is to be done in a later phase, I suggest to put TODO comments to the places where such logging should be done. What do you think?

The point of my suggested "dummy" ATTRIBUTE_NODISCARD is that it serves the purpose of such TODO comments.
If you undummify that macro then you get warnings at any places that haven't addressed the use of the return value.

-------------

PR Comment: https://git.openjdk.org/jdk/pull/25450#issuecomment-3142188027