RFR: 8364519: Sort share/classfile includes
Aleksey Shipilev
shade at openjdk.org
Fri Aug 1 11:08:54 UTC 2025
On Fri, 1 Aug 2025 10:03:39 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:
> This PR sorts the includes in hotspot/share/classfile using SortIncludes.java. I'm also adding the directory to TestIncludesAreSorted.
>
> Passes tier1.
Looks fine, with a nit.
src/hotspot/share/classfile/systemDictionary.cpp line 63:
> 61: #include "oops/objArrayOop.inline.hpp"
> 62: #include "oops/oop.hpp"
> 63: #include "oops/oop.inline.hpp"
Take this opportunity to remove the include of `oop.hpp`, since we are including `oop.inline.hpp` anyway?
-------------
Marked as reviewed by shade (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/26590#pullrequestreview-3078791694
PR Review Comment: https://git.openjdk.org/jdk/pull/26590#discussion_r2247700897
More information about the hotspot-dev
mailing list