RFR: 8364519: Sort share/classfile includes [v2]

Aleksey Shipilev shade at openjdk.org
Fri Aug 1 13:07:54 UTC 2025


On Fri, 1 Aug 2025 13:00:24 GMT, Francesco Andreuzzi <duke at openjdk.org> wrote:

>> src/hotspot/share/classfile/systemDictionary.cpp line 63:
>> 
>>> 61: #include "oops/objArrayOop.inline.hpp"
>>> 62: #include "oops/oop.hpp"
>>> 63: #include "oops/oop.inline.hpp"
>> 
>> Take this opportunity to remove the include of `oop.hpp`, since we are including `oop.inline.hpp` anyway?
>
> Sure, I got a few here: 3477cbce67776546bbb0cbc0cf18302a6dab2c97
> 
> Could this be a possible improvement of `SortIncludes.java`?

Maybe, but it is not exactly the include order issue. We do these clean ups opportunistically, when it is glaringly obvious it is an unnecessary include.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26590#discussion_r2247940487


More information about the hotspot-dev mailing list