RFR: 8361376: Regressions 1-6% in several Renaissance in 26-b4 only MacOSX aarch64 [v5]

Martin Doerr mdoerr at openjdk.org
Tue Aug 5 10:16:06 UTC 2025


On Mon, 4 Aug 2025 21:26:22 GMT, Dean Long <dlong at openjdk.org> wrote:

>> This PR removes the recently added lock around set_guard_value, using instead Atomic::cmpxchg to atomically update bit-fields of the guard value.  Further, it takes a fast-path that uses the previous direct store when at a safepoint.  Combined, these changes should get us back to almost where we were before in terms of overhead.  If necessary, we could go even further and allow make_not_entrant() to perform a direct byte store, leaving 24 bits for the guard value.
>
> Dean Long has updated the pull request incrementally with one additional commit since the last revision:
> 
>   one unconditional release should be enough

Thanks for implementing nice code for PPC64! I appreciate it! The shared code and the other platforms look fine, too.
Maybe atomic bitwise operations could be used, but I'm happy with your current solution.

-------------

Marked as reviewed by mdoerr (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/26399#pullrequestreview-3087610323


More information about the hotspot-dev mailing list