RFR: 8308094: Add a compilation timeout flag to catch long running compilations [v2]

Manuel Hässig mhaessig at openjdk.org
Tue Aug 5 10:32:07 UTC 2025


On Tue, 5 Aug 2025 03:55:35 GMT, Dean Long <dlong at openjdk.org> wrote:

>> Manuel Hässig has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
>> 
>>  - Merge branch 'master' into JDK-8308094-timeout
>>  - Fix SIGALRM test
>>  - Add timeout functionality to compiler threads
>
> src/hotspot/share/compiler/compileBroker.cpp line 236:
> 
>> 234:     {
>> 235:       MutexLocker notifier(thread, CompileTaskWait_lock);
>> 236:       thread->timeout_disarm();
> 
> Is holding the lock above important for disasming?  If not, can we move the disarms from the if/else branches and do it unconditionally before the if?

It is not. I'll move it above the `if`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/26023#discussion_r2253919668


More information about the hotspot-dev mailing list